Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Select type cell editor #10673

Merged
merged 4 commits into from Dec 19, 2023
Merged

Improve Select type cell editor #10673

merged 4 commits into from Dec 19, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Dec 19, 2023

Context

The PR improves the select-type cell editor. Changes concern:

  • Add support for Tab keys. There is the possibility to select the next/previous cell by hitting the navigation keyboard shortcuts while the editor is opened;

Things that already worked but are not described in Docs:

  • There is native support for keyboard shortcuts for opening the native dropdown list.
    • Shift+ArrowDown/ArrowUp on macOS;
    • Alt+ArrowDown/ArrowUp on Windows;

How has this been tested?

I tested the changes locally and I covered the feature with new tests.

Types of changes

  • New feature or improvement (non-breaking change which adds functionality)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/609

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Dec 19, 2023
@budnix budnix marked this pull request as ready for review December 19, 2023 12:20
@budnix budnix merged commit 1570df1 into develop Dec 19, 2023
21 checks passed
@budnix budnix deleted the feature/dev-issue-609 branch December 19, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants