Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain the last selected row/column selection after removal #10690

Merged
merged 3 commits into from Jan 4, 2024

Conversation

budnix
Copy link
Member

@budnix budnix commented Jan 2, 2024

Context

The PR restores the behavior from the 7.4.2 version, where the removed row or column selection (after record removal) did not move to the new position (nearest visible record).

Before

Kapture 2024-01-02 at 15 19 34

After

Kapture 2024-01-02 at 15 20 09

How has this been tested?

I tested the changes locally and I covered the fix with new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/371

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Jan 2, 2024
@budnix budnix marked this pull request as ready for review January 2, 2024 14:23
@budnix budnix requested a review from jansiegel January 2, 2024 21:15
Copy link

github-actions bot commented Jan 2, 2024

Launch the local version of documentation by running:

npm run docs:review d9d6212a9242fd7c9618efc9c9e2260081950cd5

@budnix budnix merged commit aa86b7d into develop Jan 4, 2024
23 checks passed
@budnix budnix deleted the feature/dev-issue-371 branch January 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants