Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with uncaught TypeError exception for some CollapsibleColumns plugin configurations #10693

Merged
merged 3 commits into from Jan 5, 2024

Conversation

wszymanski
Copy link
Contributor

Context

As the title says. Just added an extra conditional.

How has this been tested?

Manual test with different configurations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/1500

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
  • My change requires a change to the documentation.

@wszymanski wszymanski self-assigned this Jan 3, 2024
@wszymanski wszymanski changed the title Fixed problem with uncaught TypeError exception for some CollapsibleColumns configuration Fixed problem with uncaught TypeError exception for some CollapsibleColumns configuration Jan 3, 2024
@wszymanski wszymanski changed the title Fixed problem with uncaught TypeError exception for some CollapsibleColumns configuration Fixed problem with uncaught TypeError exception for some CollapsibleColumns configurations Jan 3, 2024
@wszymanski wszymanski changed the title Fixed problem with uncaught TypeError exception for some CollapsibleColumns configurations Fixed problem with uncaught TypeError exception for some CollapsibleColumns plugin configurations Jan 3, 2024
Copy link

github-actions bot commented Jan 5, 2024

Launch the local version of documentation by running:

npm run docs:review cce24edc479dc18907f29e9fe8e747373d2fa4e3

@wszymanski wszymanski merged commit d052e5d into develop Jan 5, 2024
24 checks passed
@wszymanski wszymanski deleted the feature/dev-issue-1500 branch January 5, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants