New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new beforeBeginEditing
hook
#10699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launch the local version of documentation by running: npm run docs:review 1e110794b0d82f5465a6485708c2eff6335dc44d |
jansiegel
approved these changes
Jan 11, 2024
verified with 0.0.0-next-45ef111-20240116 : https://jsfiddle.net/x73hutLm/4/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR adds a new
beforeBeginEditing
hook that allows controlling when the cell editor can (or not) be opened based on the custom condition. When the hook is not used, or if it returns a value other than a boolean, the default behavior is enabled. By default - which is changed within this PR, a cell editor can not be opened by double mouse click for non-contiguous selection (while pressing Ctrl/Cmd) and for multiple selected cells (while pressing Shift).Before
After
Hook example usage
Prevent the editor from being opened for the mouse double click. Enter or F2 or API calls would still work.
Prevent the editor from being opened for specific coordinates (row 0, column 0)
How has this been tested?
I tested the changes locally and I covered the feature with new tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: