New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve behavior of the viewport scroll after selection change #10709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launch the local version of documentation by running: npm run docs:review 6d89addac04ccae23d9ed5412df931fa45d31237 |
budnix
changed the title
[wip] Improve behavior of the viewport scroll after a cell click
Improve behavior of the viewport scroll after a cell click
Jan 15, 2024
budnix
changed the title
Improve behavior of the viewport scroll after a cell click
Improve behavior of the viewport scroll after selection change
Jan 15, 2024
jansiegel
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR improves the viewport scroll's behavior after the selection change triggered by the mouse clicks. Additionally, the PR improves/fixes other things related to the viewport scroll behavior. The PR modularizes the viewport scrolling mechanism into a separate module that handles all scroll-related things.
The PR's changes:
Features
Bug fixes
Clicking on the beginning part of the partially visible cell (feature)
The same logic covers both axies, partially visible columns, and rows.
Before
After
Clicking on the end part of the partially visible cell (feature)
As before, so, and after the PR's changes, the behavior is the same. The viewport is scrolled to the beginning of the cell.
How has this been tested?
I tested the changes locally and I covered the feature with new tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: