Execution of data getters in cells
method won't throw an error anymore in specific situation
#10710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The below schema shows how there is created an infinite loop.
This PR introduces an idea to replace calling the
getCellMeta
with using thegetCellsMeta
method. There also have been introduced changes inCellMeta
class as meta for already added row doesn't exist right after row insertion, in the time of callinggetCellsMeta
method (right after callingmodifyRow
hook). Although it already exist (it is added usingCellMeta.createRow
method) it is not ready until the firstgetMeta
call (lazy loading).How has this been tested?
Manual tests for bigger datasets and enabled Formulas plugin.
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: