Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution of data getters in cells method won't throw an error anymore in specific situation #10710

Merged
merged 5 commits into from Jan 10, 2024

Conversation

wszymanski
Copy link
Contributor

@wszymanski wszymanski commented Jan 9, 2024

Context

The below schema shows how there is created an infinite loop.

Flowchart (1)

This PR introduces an idea to replace calling the getCellMeta with using the getCellsMeta method. There also have been introduced changes in CellMeta class as meta for already added row doesn't exist right after row insertion, in the time of calling getCellsMeta method (right after calling modifyRow hook). Although it already exist (it is added using CellMeta.createRow method) it is not ready until the first getMeta call (lazy loading).

How has this been tested?

Manual tests for bigger datasets and enabled Formulas plugin.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/1501

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
  • My change requires a change to the documentation.

@wszymanski wszymanski requested a review from budnix January 9, 2024 14:53
@wszymanski wszymanski self-assigned this Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

Launch the local version of documentation by running:

npm run docs:review 828d53a3d064c36b8a2d125a3fedd149f409c8fa

@wszymanski wszymanski marked this pull request as ready for review January 9, 2024 15:36
@wszymanski wszymanski merged commit 419c4e3 into develop Jan 10, 2024
21 checks passed
@wszymanski wszymanski deleted the feature/dev-issue-1501 branch January 10, 2024 14:19
jansiegel pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants