Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update peerDependencies of vue3 wrapper #10712

Merged
merged 1 commit into from Jan 10, 2024

Conversation

0xJacky
Copy link
Contributor

@0xJacky 0xJacky commented Jan 10, 2024

Context

The following warning occurs when I using pnpm to install @handsontable/vue3
image

You can check the vue tag and verison in https://www.npmjs.com/package/vue?activeTab=versions, and there is no next tag anymore, so I use ^3.2.22 as the peerDependencies verison which is also the verison of vue in dependencies.

How has this been tested?

I rebuilt the @handsontable/vue3, published it to my private npm registry, and use it as the dependency.

Then, I executed pnpm install again, no warning apeared.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. [Bug]: peer dependence vue@next will stop the build process in pnpm. #10571

Affected project(s):

  • @handsontable/vue3

Checklist:

@budnix
Copy link
Member

budnix commented Jan 10, 2024

@0xJacky Can I ask to add a changelog file? You can generate one by running the npm run changelog entry command in the root directory of the mono repo.

@0xJacky
Copy link
Contributor Author

0xJacky commented Jan 10, 2024

ok, I will add it.

@AMBudnik
Copy link
Contributor

Hi @0xJacky

I can see that you checked the Contributor License Agreement checkbox, but unfortunately I do not see your signature. Without it, we won't be able to pull the changes. Could you please fit it up again?

@0xJacky
Copy link
Contributor Author

0xJacky commented Jan 10, 2024

Sorry, I sign it now.

@AMBudnik
Copy link
Contributor

Now I can see it. Thank you.

@budnix budnix self-requested a review January 10, 2024 08:09
@budnix budnix merged commit c129d3f into handsontable:develop Jan 10, 2024
18 of 19 checks passed
@AMBudnik
Copy link
Contributor

Hi @0xJacky

I just wanted to let you know that we published the changes within Handsontable v14.1.0.

Thank you again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants