Add pikaday to peerDependencies to ensure backward compatibility for 14.1.0.
#10715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budnix
approved these changes
Jan 10, 2024
jansiegel
added a commit
that referenced
this pull request
Jan 10, 2024
…for `14.1.0`. (#10715) * Add peer dependencies for pikaday and @types/pikaday * Regenerate the package-lock file. * Add the changelog entry.
jansiegel
added a commit
that referenced
this pull request
Jan 11, 2024
…ensure yarn support for the fix from #10715.
12 tasks
jansiegel
added a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds:
pikaday@types/pikadayto
handsontable'speerDependenciesto ensure the backward compatibility of the14.1.0release.With the release of
15.0.0, these changes should be reverted.How has this been tested?
Created a sample project with
handsontableas a dependency which importspikaday. After these changes, the project built correctly.Types of changes
Related issue(s):
Affected project(s):
handsontable@handsontable/angular@handsontable/react@handsontable/vue@handsontable/vue3Checklist: