New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cells pasted from clipboard's tables won't contain unnecessary line breaks #10745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launch the local version of documentation by running: npm run docs:review 0da32502d5a0adfc5aade15601dac5a6d240ddfb |
jansiegel
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @magierg Unfortunately I'm not able to test it myself with MS Word, could I ask for your help with this?
- @wszymanski it's not a breaking change, correct?
- The code LGTM
Correct. |
magierg
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The described bug also occurs for MacOS and Chrome browser. I've found a case which shows that problem. Finally, after a deeper investigation, I've discovered that it's not related only to Word files and tables inside them. The issue relates to how we parsed whitespaces as part of the HTML snippet. Word splits long text into a few lines for better readability. Until now, extra spaces (added to break text) have been preserved. That won't be done anymore. The only spaces are stored as
 
elements inside HTML elements, and we filter out other space characters.How has this been tested?
Tested different tables with spaces at the start and the end of a single line/whole snippet.
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: