Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem with the dropdown editor throwing an error when the cell value was represented by a td outside of the initial editor viewport. #10763

Merged
merged 3 commits into from Feb 5, 2024

Conversation

jansiegel
Copy link
Member

Context

This PR modifies the autocompleteEditor's afterSelection hook callback to afterSelectionEnd to allow targeting the selected td element.
The afterSelection hook fires before the table is scrolled into position, so the selected cell may not be rendered yet at this point.

How has this been tested?

Added a test case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1724

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@jansiegel jansiegel requested a review from budnix February 2, 2024 12:18
@jansiegel jansiegel self-assigned this Feb 2, 2024
Copy link

github-actions bot commented Feb 5, 2024

Launch the local version of documentation by running:

npm run docs:review 5b34bbc90bebc34b8eae1ada2363924b4566caf0

@jansiegel jansiegel merged commit 49293f5 into develop Feb 5, 2024
23 checks passed
@jansiegel jansiegel deleted the feature/dev-issue-1724 branch February 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants