Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way checkbox-typed cells react to pressing SPACE and ENTER keys. #10802

Merged
merged 4 commits into from Feb 23, 2024
Merged

Change the way checkbox-typed cells react to pressing SPACE and ENTER keys. #10802

merged 4 commits into from Feb 23, 2024

Conversation

jansiegel
Copy link
Member

@jansiegel jansiegel commented Feb 22, 2024 •
edited by evanSe

Context

This PR changes the way checkbox-typed cells react to pressing SPACE and ENTER keys.

Before:

  • Pressing SPACE/ENTER on a selection containing checkbox-typed cells reversed their state

After:

  • If all the checkboxes in a selection share the same value:
    • Their values get reversed.
  • If the selected checkboxes differ in values:
    • All of the checkboxes are marked as checked.

How has this been tested?

  • Modified the existing test cases
  • Added new ones for the changed functionality

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1747

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@jansiegel
- Change the way checkbox-typed cells react to pressing SPACE and ENT…
6016c9a 
…ER keys.

- Modify the existing test cases and add new ones.
@jansiegel jansiegel self-assigned this Feb 22, 2024
@github-actions GitHub Actions
Copy link

Launch the local version of documentation by running:

npm run docs:review e16f770d5c0752d2355b1d84d0c0b23b81523f52

@budnix budnix self-requested a review February 22, 2024 14:01
budnix
budnix previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@budnix budnix left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked. It looks like everything works as described 👌

@jansiegel jansiegel marked this pull request as ready for review February 23, 2024 09:11
@jansiegel jansiegel merged commit 4832dd2 into develop Feb 23, 2024
21 checks passed
@jansiegel jansiegel deleted the feature/dev-issue-1747 branch February 23, 2024 09:23
jansiegel added a commit that referenced this pull request Feb 27, 2024
@jansiegel
Modify the change from #10802 to not distinguish between sub-selectio…
810eb21 
…ns when modifying the checkboxes' state by hitting space/enter.
@jansiegel jansiegel mentioned this pull request Feb 27, 2024
Merged
4 tasks
jansiegel added a commit that referenced this pull request Feb 27, 2024
@jansiegel
Modify the change from #10802 to not distinguish between sub-selectio…
678a6b1 
…ns when modifying the checkboxes' state by hitting space/enter. (#10826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnix budnix budnix approved these changes

Assignees

@jansiegel jansiegel

Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jansiegel @budnix @AMBudnik