Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React wrapper: Add a check that only HotColumn instances are children of HotTable #10805

Conversation

NOtherDev
Copy link

Context

The structure of components in React wrapper is now straightforward: HotTable contains zero or more HotColumn children and nothing else, and HotColumn never have children. Any other scenario is incorrect and throws a warning.

How has this been tested?

  • all the unit tests + new unit tests for the feature passing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Proposal in RFC

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@NOtherDev NOtherDev changed the title Add a check that only HotColumn instances are children of HotTable React wrapper: Add a check that only HotColumn instances are children of HotTable Feb 22, 2024
@NOtherDev NOtherDev marked this pull request as ready for review February 22, 2024 14:39
@evanSe evanSe merged commit b92a133 into handsontable:feature/improved-react Feb 22, 2024
16 of 18 checks passed
@NOtherDev NOtherDev deleted the feature/improved-react-6-childrencheck branch February 23, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants