Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code samples to separate files and update links in documentation #10837

Merged
merged 14 commits into from
Mar 7, 2024

Conversation

adrianspdev
Copy link
Contributor

@adrianspdev adrianspdev commented Mar 4, 2024

Context

This PR includes code examples improvement in guides directory

How has this been tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/1779

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

  • Move all guides md files to folder with filename
  • Move code samples to separate files and place it in folder with md filename / framework name
  • Replace code samples with code location snippet like @code
  • Update sidebar paths
  • Update code examples links in documentation

[skip changelog]

Copy link

github-actions bot commented Mar 5, 2024

Launch the local version of documentation by running:

npm run docs:review 05d7cdeb7a94a48599475d3c9757ba3aa72f0ed7

@evanSe evanSe merged commit 221e46b into develop Mar 7, 2024
22 checks passed
@evanSe evanSe deleted the feature/dev-issue-1779 branch March 7, 2024 13:36
evanSe added a commit that referenced this pull request Mar 11, 2024
* Added beforeBeginEditing hook to the Cell editor guide API list (#10844)

* Move code samples to separate files and update links in documentation (#10837)

* include code snippets

* Move code samples to separate files and update links in documentation

* update demo file

* Revert "Move code samples to separate files and update links in documentation"

This reverts commit 1ea5f1d.

* Move code samples to separate files and update links in documentation

* fixup typo

* fix typo

* Update ESLint configuration and auto fix lint issues

* fix lint

* update angular demo

* revert replaced dist files

---------

Co-authored-by: Evan Seaward <seaward.evan@gmail.com>

* React wrapper: Sync updated docs with new structure

---------

Co-authored-by: Aleksandra Budnik <AMBudnik@users.noreply.github.com>
Co-authored-by: adrianspdev <155736789+adrianspdev@users.noreply.github.com>
Co-authored-by: Evan Seaward <seaward.evan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants