Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added beforeBeginEditing hook to the Cell editor guide API list #10844

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

AMBudnik
Copy link
Contributor

@AMBudnik AMBudnik commented Mar 7, 2024

Context

As in https://github.com/handsontable/dev-handsontable/issues/1789 we introduced a new hook in v14.2 and should link it on the Cell editor page.

How has this been tested?

Locally

Types of changes

  • change in the docs

Related issue(s):

  1. https://github.com/handsontable/dev-handsontable/issues/1789

Affected project(s):

  • docs

Checklist:

  • My change requires a change to the documentation.

[skip changelog]

@AMBudnik AMBudnik requested a review from evanSe March 7, 2024 08:55
Copy link

github-actions bot commented Mar 7, 2024

Launch the local version of documentation by running:

npm run docs:review 51e22406c7cc05b6c55652e746a0577310f195b9

Copy link
Member

@evanSe evanSe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AMBudnik AMBudnik merged commit 8e49c6c into develop Mar 7, 2024
22 of 23 checks passed
@AMBudnik AMBudnik deleted the feature/dev-issue-1789 branch March 7, 2024 10:42
evanSe added a commit that referenced this pull request Mar 11, 2024
* Added beforeBeginEditing hook to the Cell editor guide API list (#10844)

* Move code samples to separate files and update links in documentation (#10837)

* include code snippets

* Move code samples to separate files and update links in documentation

* update demo file

* Revert "Move code samples to separate files and update links in documentation"

This reverts commit 1ea5f1d.

* Move code samples to separate files and update links in documentation

* fixup typo

* fix typo

* Update ESLint configuration and auto fix lint issues

* fix lint

* update angular demo

* revert replaced dist files

---------

Co-authored-by: Evan Seaward <seaward.evan@gmail.com>

* React wrapper: Sync updated docs with new structure

---------

Co-authored-by: Aleksandra Budnik <AMBudnik@users.noreply.github.com>
Co-authored-by: adrianspdev <155736789+adrianspdev@users.noreply.github.com>
Co-authored-by: Evan Seaward <seaward.evan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants