Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React wrapper: Simplify useHotEditor API #10845

Conversation

NOtherDev
Copy link

@NOtherDev NOtherDev commented Mar 8, 2024

Context

Follow-up on improving custom component-based editor developer experience as proposed by @evanSe in #10831 (comment).

How has this been tested?

  • all unit tests still pass
  • examples still run correctly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Improving React Developer Experience #10831 (comment)

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

[skip changelog]

@NOtherDev NOtherDev self-assigned this Mar 8, 2024
@NOtherDev NOtherDev marked this pull request as ready for review March 8, 2024 12:54
@NOtherDev NOtherDev marked this pull request as draft March 8, 2024 13:00
@NOtherDev NOtherDev marked this pull request as ready for review March 8, 2024 20:20
@evanSe
Copy link
Member

evanSe commented Mar 11, 2024

@NOtherDev Looks great!

@evanSe evanSe merged commit 49cdb35 into handsontable:feature/improved-react Mar 11, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants