Make the source
argument for setDataAtCell
in the Merge Cells plugin more specific.
#10857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Merge Cells plugin utilizes
populateFromArray
andsetDataAtCell
methods to fill the cells under the merged cells withnull
s.Currently, the
source
argument given in thebeforeChange
/afterChange
hooks differed between the following use cases:source
was defined asedit
(used to bepopulateFromArray
).source
was defined asMergeCells
.After the change introduced in this PR, both cases will be passing the
source
argument asMergeCells
.I think in both cases, the
source
should be more specific, likeMergeCells.clearCells
, but the change could be considered breaking, so I think we should maybe introduce this change with the next major release. WDYT @evanSe?How has this been tested?
Added a test case.
Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: