Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain focus after column collapsing #10865

Merged
merged 7 commits into from Apr 3, 2024
Merged

Conversation

budnix
Copy link
Member

@budnix budnix commented Mar 22, 2024

Context

The PR changes make the focused cell always visible after the column collapsing.

If the current selection becomes collapsed, the focus is moved to the first visible column to the right. If no visible columns exist on the right, it's moved to the first column on the left (relative to the original focus position). If neither the right nor left columns are visible. The focus is never hidden.

Kapture 2024-03-22 at 12 47 14

How has this been tested?

I tested the changes locally, and I covered the fix with new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes https://github.com/handsontable/dev-handsontable/issues/1750

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Mar 22, 2024
@budnix budnix requested a review from jansiegel March 25, 2024 07:54
Copy link

github-actions bot commented Mar 25, 2024

Launch the local version of documentation by running:

npm run docs:review a749ba9c80079f8f12674406928d4db1ba16a3dd

@budnix budnix merged commit 5d3f934 into develop Apr 3, 2024
24 checks passed
@budnix budnix deleted the feature/dev-issue-1750 branch April 3, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants