Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the bottom/right cell borders are visible in the viewport after scrolling from the absolute top/absolute left table position. #10887

Merged
merged 9 commits into from Apr 3, 2024

Conversation

jansiegel
Copy link
Member

Context

This PR:

  • Adds a 1px row/column header border compensation to the scroll values when scrolling from the absolute top/absolute left positions of the table using the API.
  • Modifies the test cases to match the new scroll values. I went through all of them to make sure they were correct. In some cases, it's up for debate (for example, in the case explained in the first bullet point, the offset cols/rows are now loaded differently), but I don't think this should negatively impact the scrolling in general.
  • Adds a new test case to ensure the borders are visible after scrolling.

How has this been tested?

Tested manually + added a new test case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. handsontable/dev-handsontable#1772

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

…te top/absolute left position of the table

- Modify the test cases to match the new scrollLeft/scrollTop values
- Add a test case ensuring the cell borders are visible after scrolling
@jansiegel jansiegel self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Launch the local version of documentation by running:

npm run docs:review 052fd0094eb6e1bba40f80bb364924c718d6155c

@jansiegel jansiegel requested a review from budnix April 3, 2024 10:40
@jansiegel jansiegel marked this pull request as ready for review April 3, 2024 10:47
@jansiegel jansiegel merged commit 53a190b into develop Apr 3, 2024
21 checks passed
@jansiegel jansiegel deleted the feature/dev-issue-1772 branch April 3, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants