Make the Vue/Vue3 wrappers' simpleEqual helper correctly recognize the same objects.
#10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budnix
approved these changes
Apr 8, 2024
evanSe
pushed a commit
that referenced
this pull request
Apr 17, 2024
…the same objects. (#10896) * Make the `simpleEqual` function recognize the same array passed twice as the same array. * Fix the lint errors * Add the changelog entry. * Corrent the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes a problem where the Vue/Vue3 wrappers'
simpleEqualfunction treated object-based config options as a circular reference, thus performing additional unneeded updates.How has this been tested?
Added a test case.
Types of changes
Related issue(s):
Affected project(s):
handsontable@handsontable/angular@handsontable/react@handsontable/vue@handsontable/vue3Checklist: