Block the wheel -> scrollTop
/scrollLeft
assignment when window
is the instance's scrollable container.
#10996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The problem in handsontable/dev-handsontable#1902 was caused by the
dragToScroll
logic readingwindow
'sscrollTop
property, which shouldn't be defined at all.Before this PR, the
wheel
event was translated into deltas that were supposed to be assigned to the scrollable container'sscrollTop
/scrollLeft
properties. In cases of window-scrolled instances, it resulted in thewindow
'sscrollTop
/scrollLeft
properties havingNaN
as a value, which messed up thedragToScroll
logic.After this change, the logic remains the same for container-scrolled instances, but window-scrolled instances ignore that.
How has this been tested?
Added a test case checking if triggering the
wheel
event on the instance results in attempts to assignscrollTop
/scrollLeft
properties ofwindow
.Types of changes
Related issue(s):
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: