correctly count the syncCalculationLimit in autoRowSize #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budnix
requested changes
Oct 23, 2018
| @@ -478,4 +478,19 @@ describe('AutoRowSize', () => { | |||
|
|
|||
| expect(rowHeight(spec().$container, -1)).toBe(75); | |||
| }); | |||
|
|
|||
| it('should properly count height', () => { | |||
There was a problem hiding this comment.
I think that this test doesn't cover this bug correctly. When I attached the older version of the handsontable to this test it passes, should fail. Can you check that?
budnix
approved these changes
Oct 26, 2018
budnix
added a commit
that referenced
this pull request
Oct 31, 2018
Fixes several issues such as: * syncCalculationLimit for AutoRowSize plugin which can cause undesired results after #5530 fixes; * syncCalculationLimit for AutoColumnSize plugin which broken dropdown menu for filters (previously fixed in #5508); * Add an attribute to TD element generated by GhostTable which creates an ability to skip renderers' logic when the Handsontable calculates the columns' width.
6 tasks
budnix
added a commit
that referenced
this pull request
Oct 31, 2018
Fixes several issues such as: * syncCalculationLimit for AutoRowSize plugin which can cause undesired results after #5530 fixes; * syncCalculationLimit for AutoColumnSize plugin which broken dropdown menu for filters (previously fixed in #5508); * Add an attribute to TD element generated by GhostTable which creates an ability to skip renderers' logic when the Handsontable calculates the columns' width.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Related issue(s):
Checklist: