Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external modules from jsdoc @dependencies tag #5546

Merged
merged 1 commit into from Oct 29, 2018

Conversation

budnix
Copy link
Member

@budnix budnix commented Oct 26, 2018

Context

hot-builder no more supports 3rd parties dependencies defined as jsdoc tag @Dependencies. This PR removes all unsupported modules.

How has this been tested?

To test this PR clone the repo and try to build it using the latest version of hot-builder. Command to build files looks like hot-builder build -i cloned-handsontable/ -o hot-dist/.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. [3.0.0+] Handsontable v3.0.0 doesn't build via hot-builder #5287

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@wszymanski wszymanski assigned budnix and unassigned wszymanski Oct 29, 2018
@budnix budnix merged commit b3482dd into develop Oct 29, 2018
@budnix budnix deleted the feature/issue-5187 branch October 29, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants