Fix an error related to not found external module #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue related to external modules like
moment,pikadayandzeroclipboardwhich are marked as needed (for example https://github.com/handsontable/handsontable/blob/master/src/editors/dateEditor.js#L15) in the source code of the Handsontable. The external modules were never be supported like this.To fix hot-builder for all affected Handsontable versions (2.0.0 to 6.1.1)
itemDescriptormodule was modified to take only dependencies which started with a capital letter - this indicates that this is an internal Handsontable module dependency.Connected PRs (handsontable/handsontable#5546 and handsontable/handsontable-pro#169) were created which removes these modules from a jsdoc tag.
Command to test:
Issue: #27