Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseEditor to ES6 #5628

Merged
merged 7 commits into from Dec 7, 2018

Conversation

Projects
None yet
4 participants
@swistach
Copy link
Member

swistach commented Nov 30, 2018

Context

Based on @aaronbeall's PR #5447 + added @jansiegel's suggestions.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Related issue(s):

  1. #5403

aaronbeall and others added some commits Nov 28, 2018

Convert BaseEditor to use ES6 class and arrow function scope (#5447)
* Convert BaseEditor to use ES6 class and arrow function scope

* Fix lint issues

* Moved export default to separate statement to match existing style

* Fixed extend() to not assume extending BaseEditor

@swistach swistach added this to the December 2018 milestone Nov 30, 2018

@swistach swistach self-assigned this Nov 30, 2018

@swistach swistach changed the title Refactor SelectEditor to ES6 Refactor BaseEditor to ES6 Nov 30, 2018

swistach added some commits Nov 30, 2018

@swistach swistach requested a review from jansiegel Dec 3, 2018

@swistach swistach assigned jansiegel and unassigned swistach Dec 3, 2018

@swistach swistach requested review from budnix and removed request for jansiegel Dec 6, 2018

@swistach swistach assigned budnix and unassigned jansiegel Dec 6, 2018

Show resolved Hide resolved test/unit/mixins/hooksRegisterer.spec.js Outdated
Show resolved Hide resolved src/mixins/hooksRegisterer.js Outdated
Show resolved Hide resolved src/editors/_baseEditor.js
Show resolved Hide resolved src/editors/_baseEditor.js Outdated

@budnix budnix assigned swistach and unassigned budnix Dec 6, 2018

@swistach swistach assigned budnix and unassigned swistach Dec 6, 2018

@budnix

budnix approved these changes Dec 7, 2018

@budnix budnix assigned swistach and unassigned budnix Dec 7, 2018

@swistach swistach merged commit b083df8 into develop Dec 7, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (budnix) No new issues
Details

@swistach swistach deleted the feature/baseEditorES6 branch Dec 7, 2018

@wojciechczerniak wojciechczerniak referenced this pull request Dec 11, 2018

Closed

Refactor ES5 to ES6 code #5403

11 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.