Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ES5 to ES6 code #5403

Closed
wojciechczerniak opened this Issue Sep 14, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@wojciechczerniak
Copy link
Member

wojciechczerniak commented Sep 14, 2018

Description

Looks like some files are still in ES5. Quick refactor to ES6 will help us a lot.

Your environment

  • Handsontable version: 5.0.2
  • Browser Name and version: all
  • Operating System: all

@wojciechczerniak wojciechczerniak added this to the October 2018 milestone Sep 14, 2018

@aaronbeall

This comment has been minimized.

Copy link
Contributor

aaronbeall commented Oct 1, 2018

I can help with this, would you accept PRs?

@wojciechczerniak

This comment has been minimized.

Copy link
Member Author

wojciechczerniak commented Oct 2, 2018

That would be awesome! A pure rewrite to ES6 without any fixes and one PR per file will speed up the review process. Just skip the last one (core.js), we still have to figure out how to deal with it.

@aaronbeall

This comment has been minimized.

Copy link
Contributor

aaronbeall commented Oct 2, 2018

Cool. Looking through a few of the files it looks like there's some ES6 there already, like let, const, and arrow functions. Is the main goal to convert constructors and prototype members to use class syntax?

@wojciechczerniak

This comment has been minimized.

Copy link
Member Author

wojciechczerniak commented Oct 3, 2018

We did some work recently with let and const to fix ESLint warnings. You're right, that's the main goal. And to use native class extends instead extend() method (but we should keep it for backward compatibility if possible). If you have any other ideas let us know.

@aaronbeall

This comment has been minimized.

Copy link
Contributor

aaronbeall commented Oct 3, 2018

@wojciechczerniak Are you using static or class property initializers?

@wojciechczerniak

This comment has been minimized.

Copy link
Member Author

wojciechczerniak commented Oct 8, 2018

Sorry about the late answer. I've handed over the issue to the developers. They will explain everything during code review for PRs you've already started. BTW Great work, thanks!

@wojciechczerniak

This comment has been minimized.

Copy link
Member Author

wojciechczerniak commented Mar 7, 2019

Released. Documentation for custom editor is tracked here handsontable/docs#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.