Refactor ES5 to ES6 code

[wojciechczerniak]

Description

Looks like some files are still in ES5. Quick refactor to ES6 will help us a lot.

• Editors:
  • BaseEditor PR: Convert BaseEditor to use ES6 class and arrow function scope #5447 ➡️ Refactor BaseEditor to ES6 #5628
  • AutocompleteEditor PR: Convert AutocompleteEditor to ES6 #5448 ➡️ Refactor AutocompleteEditor to ES6 #5650
  • HandsontableEditor PR: Convert HandsontableEditor to ES6 class #5452 ➡️ Refactor HandsontableEditor to ES6 #5653
  • SelectEditor PR: Convert SelectEditor to ES6 #5451 ➡️ Refactor SelectEditor to ES6 #5618
  • TextEditor PR: Convert TextEditor to ES6 class #5450 ➡️ Refactor TextEditor to ES6 #5646
  • Update docs for custom editor https://handsontable.com/docs/6.2.0/tutorial-cell-editor.html (should solve https://github.com/handsontable/angular-handsontable/issues/127) Related docs issue: https://github.com/handsontable/docs/issues/21
• Walkontable
  • Event PR: Refactor Walkontable.Event to ES6 #5655
• EditorManager PR: Refactor editorManager to ES6 #5683
• MultiMap PR: Remove MultiMap from Datamap #5660
• TableView PR: Refactor TableView to ES6 #5690
• DefaultSettings
• DataMap PR: Refactor dataMap to ES6 #5699
• Core

Your environment

• Handsontable version: 5.0.2
• Browser Name and version: all
• Operating System: all

[aaronbeall]

I can help with this, would you accept PRs?

[wojciechczerniak]

That would be awesome! A pure rewrite to ES6 without any fixes and one PR per file will speed up the review process. Just skip the last one (core.js), we still have to figure out how to deal with it.

[aaronbeall]

Cool. Looking through a few of the files it looks like there's some ES6 there already, like let, const, and arrow functions. Is the main goal to convert constructors and prototype members to use class syntax?

[wojciechczerniak]

We did some work recently with let and const to fix ESLint warnings. You're right, that's the main goal. And to use native class extends instead extend() method (but we should keep it for backward compatibility if possible). If you have any other ideas let us know.

[aaronbeall]

@wojciechczerniak Are you using static or class property initializers?

[wojciechczerniak]

Sorry about the late answer. I've handed over the issue to the developers. They will explain everything during code review for PRs you've already started. BTW Great work, thanks!

[wojciechczerniak]

Released. Documentation for custom editor is tracked here https://github.com/handsontable/docs/issues/21