Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AutocompleteEditor to ES6 #5650

Merged
merged 9 commits into from
Dec 12, 2018
Merged

Conversation

mrpiotr-dev
Copy link
Contributor

Context

Based on @aaronbeall's PR #5448 + added @jansiegel's suggestions.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Related issue(s):

  1. Refactor ES5 to ES6 code #5403

* Convert to ES6 class syntax

* Moved export default to separate statement to match existing style
@mrpiotr-dev mrpiotr-dev self-assigned this Dec 10, 2018
@mrpiotr-dev mrpiotr-dev changed the title Refactor SelectEditor to ES6 Refactor AutocompleteEditor to ES6 Dec 10, 2018
@mrpiotr-dev mrpiotr-dev assigned budnix and unassigned mrpiotr-dev Dec 11, 2018
@wojciechczerniak wojciechczerniak mentioned this pull request Dec 11, 2018
13 tasks
src/editors/autocompleteEditor.js Outdated Show resolved Hide resolved
src/editors/autocompleteEditor.js Show resolved Hide resolved
src/editors/autocompleteEditor.js Show resolved Hide resolved
src/editors/autocompleteEditor.js Show resolved Hide resolved
src/editors/autocompleteEditor.js Show resolved Hide resolved
src/editors/autocompleteEditor.js Show resolved Hide resolved
src/editors/autocompleteEditor.js Outdated Show resolved Hide resolved
@budnix budnix assigned mrpiotr-dev and unassigned budnix Dec 11, 2018
@mrpiotr-dev mrpiotr-dev assigned budnix and unassigned mrpiotr-dev Dec 12, 2018
src/editors/autocompleteEditor.js Outdated Show resolved Hide resolved
@budnix budnix assigned mrpiotr-dev and unassigned budnix Dec 12, 2018
@mrpiotr-dev mrpiotr-dev assigned budnix and unassigned mrpiotr-dev Dec 12, 2018
budnix
budnix previously approved these changes Dec 12, 2018
@budnix budnix assigned mrpiotr-dev and unassigned budnix Dec 12, 2018
budnix
budnix previously approved these changes Dec 12, 2018
@mrpiotr-dev mrpiotr-dev assigned mrpiotr-dev and unassigned budnix Dec 12, 2018
@mrpiotr-dev mrpiotr-dev assigned budnix and unassigned mrpiotr-dev Dec 12, 2018
@mrpiotr-dev mrpiotr-dev assigned mrpiotr-dev and unassigned budnix Dec 12, 2018
@mrpiotr-dev mrpiotr-dev merged commit 9cef5ac into develop Dec 12, 2018
@mrpiotr-dev mrpiotr-dev deleted the feature/autocompleteEditorES6 branch December 12, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants