Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dataMap to ES6 #5699

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@swistach
Copy link
Member

swistach commented Jan 2, 2019

Context

Refactored dataMap to ES6 with necessary JSDocs annotations.

How has this been tested?

Everything should work as before.

Types of changes

  • Bug fix / Refactor (a non-breaking change which fixes an issue)

Related issue(s):

  1. #5403

swistach added some commits Jan 2, 2019

@swistach swistach self-assigned this Jan 2, 2019

@wojciechczerniak wojciechczerniak referenced this pull request Jan 2, 2019

Closed

Refactor ES5 to ES6 code #5403

11 of 13 tasks complete

@swistach swistach requested a review from budnix Jan 3, 2019

@swistach swistach assigned budnix and unassigned swistach Jan 3, 2019

Show resolved Hide resolved src/dataMap.js Outdated
Show resolved Hide resolved src/dataMap.js Outdated
Show resolved Hide resolved src/dataMap.js Outdated
Show resolved Hide resolved src/dataMap.js Outdated
Show resolved Hide resolved src/dataMap.js Outdated
Show resolved Hide resolved src/dataMap.js Outdated
Show resolved Hide resolved src/dataMap.js Outdated
Apply suggestions from code review
Co-Authored-By: swistach <swistach@users.noreply.github.com>

@swistach swistach assigned swistach and budnix and unassigned budnix and swistach Jan 3, 2019

@budnix

budnix approved these changes Jan 3, 2019

@swistach swistach merged commit 2093d85 into develop Jan 3, 2019

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - package.json (krzysztofspilka) No new issues
Details

@swistach swistach deleted the feature/dataMapES6 branch Jan 3, 2019

@swistach swistach assigned swistach and unassigned budnix Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.