Configurable ContextMenu's container #6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead document.documentElement. #6283
…s correct if documents are different. #6283
jansiegel
pushed a commit
that referenced
this pull request
Nov 4, 2019
* Changed: contextMenu uses configurable container. #6283 * Changed: contextMenu's positioning to support iframe. Adjustment in dragToScroll, #6283 * Changed: event propagation for right click on contextMenu items. Reverted changes for mixed frames event propagation onkeydown. #6283 * Changed: prevented opening native context menu by clicking the right mouse button on ContextMenu's item. #6283 * Changed: contextMenu/dropdownMenu/FilterUISelect executes command on hook instead of . First part of test specs adjustments. #6283 * Adjusted: contextMenu's items will be executed on mouseup/contextmenu events. #6283 * Changed: property name of UI container. Added: test specs for custom UI container. #6283 * Changed: dropdownMenu requires colHeaders to work. #6283 * Added: tests for added functionalities. #6283 * Changed: default container for ContextMenu should be document.body instead document.documentElement. #6283 * Changed: position's calculations have to base on event.view's scroll too. [skip ci] #6283 * Added: test scenario to verify contextmenu UI elements' positioning is correct if documents are different. #6283
6 tasks
budnix
added a commit
that referenced
this pull request
Nov 29, 2019
It seems that changing fragmentSelection to `false` doesn't make any problems with selection. So I reverted the change as originally introduced in #6304
This was referenced Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently,
rootDocument.bodyis a hard-coded container for ContextMenu's elements. Thanks to these changes, it will be possible to define the container.Changes are backward compatible - if
contextMenu.uiContaineris not defined, thererootDocument.bodyis used.How has this been tested?
Add
uiContainerproperty to thecontextMenuoption on initialization.Types of changes
Related issue(s):