Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing setting - skipRowOnPaste #7394

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Add missing setting - skipRowOnPaste #7394

merged 2 commits into from
Nov 18, 2020

Conversation

AMBudnik
Copy link
Contributor

Context

This pull request adds the missing skipRowOnPaste setting.
This option is mentioned in the docs but hasn't been added to our .ts files.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. The skipRowOnPaste option is missing in the typings #7393

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation.

@AMBudnik
Add missing setting
ae02456 
Added the missing skipRowOnPaste setting and set it to 'true'.
@AMBudnik AMBudnik requested a review from pnowak November 17, 2020 14:02
@AMBudnik
Add missing setting
1eb51fb 
Added the 'skipRowOnPaste' option.
pnowak
pnowak approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@pnowak pnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1eb51fb:

Sandbox Source
handsontable/examples: pull-request Configuration
handsontable/examples: pull-request Configuration
handsontable/examples: pull-request Configuration
handsontable/examples: pull-request Configuration

@AMBudnik AMBudnik changed the title Add missing setting Add missing setting - skipRowOnPaste Nov 18, 2020
@AMBudnik AMBudnik merged commit b9ec4db into develop Nov 18, 2020
@AMBudnik AMBudnik deleted the TS-fixes branch November 18, 2020 12:36
@aninde
Copy link
Contributor

aninde commented Jan 27, 2021

Commits are included in the v8.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowak pnowak pnowak approved these changes

Assignees
No one assigned
Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMBudnik @aninde @pnowak