Monorepo Phase 2 #7434
Merged
Monorepo Phase 2 #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i. @handsontable/angular ii. @handsontable/react iii. @handsontable/vue to the './wrappers/' subdirectory, - Configure npm workspaces for the wrappers, - Add a link to the root directory under './packages/handsontable', because of an issue with generating 'package-lock.json', - Add scripts for: i. running commands on specific projects ii. running commands for all projects iii. recognizing the context for running tests only for specific projects - Add the config for Codesandbox CI,� - Update some of the dependencies, to be compatible with npm@7's auto-installing peerDependencies, - Modify and/or create issue templates, PR templates and other content, - Update urls to the wrappers in READMEs, - Add (and temporarily disable) new eslint options. (#7380)
- Modify the packages' dependencies to fix npm audit errors. #7380
- Add a first version of the release-scheduling script (will be extended with bundle verification etc) #7380
- Unify the typescript version across the packages�. - Clean up some of the unused dependencies. - Bump some versions to be compatible with the typescript version. - Bump the angular version to 9 (along with some of the dependencies) in the angular wrapper + disable Ivy for compatibility.
- Add npm scripts for freezing, releasing and publishing + unify their naming between the packages. - Rename the scripts from camelCase to kebab-case. - Modify the freezing script with the commit/push functionality, along with some fixes. - Add a release script. - Modify the angular wrapper's version static to make it work with older TS versions, after changing its' dependency from Angular 8 to Angular 9. - Modify the GH actions config to use Node 15 instead of 12.
…in the future) - Remove the wrapper entries from the codesandbox config (temporarily) - Add a safenet to the release script to prevent accidental release pushes to master (the --push argument) - Add a script to re-link local packages in node_modules (needed after the modularization merge) - Add a eslint-disabling comment to one of the files (bug in the eslint-plugin-import package)
… script exists). - Simplify some scripts. - Add the changelog entry. - Correct the codesandbox ci script, to (temporarily) build only handsontable.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4fcbf3e:
|
- Add a forced handsontable build in the targeted test script. - Add an error message in the node_modules linking script.
- Refresh package-lock. - Fix the delegate-command script.
6 tasks
budnix
reviewed
Jan 27, 2021
|
Ok, I can continue my insight, and here are my thoughts:
|
budnix
reviewed
Jan 28, 2021
- Get rid of all eslint-disabling comments in favor of a eslint exceptions for the 'scripts' directory. - Correct the targeted tests script to accept commits with no projects changed. - Extend yargs config for the targeted tests script.
budnix
reviewed
Feb 15, 2021
Co-authored-by: Krzysztof Budnik <571316+budnix@users.noreply.github.com>
budnix
reviewed
Feb 15, 2021
budnix
reviewed
Feb 15, 2021
budnix
reviewed
Feb 15, 2021
budnix
reviewed
Feb 15, 2021
- Apply the post-CR suggestions.
…ontable/handsontable into feature/issue-7380-phase-2
wojciechczerniak
previously approved these changes
Feb 16, 2021
Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>
…ontable/handsontable into feature/issue-7380-phase-2
- Modify the spawnProcess helper.
budnix
approved these changes
Feb 17, 2021
|
Nicely done @jansiegel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Additional scripts and functionalities for the monorepo.
Known issues:
npm@<7, which makes it impossible to utilize thenpm workspacesfunctionality. It has been temporarily configured to build onlyhandsontable.@handsontable/angularpackage displays warnings during the build. It's caused by using Node 14+ and thestylusdependency of Angular 9. The warnings were fixed in the latest version ofstylus, but it would require us to update to Angular 10.Related issue(s):
Checklist: