Fix circular dependencies in the i18n module #7495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, the commit fixes the code formatting by splitting the summary exports into export assigned to particular functions. This prevents jumping between function declaration or so and exports.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9802e4a:
|
mrpiotr-dev
approved these changes
Jan 26, 2021
budnix
added a commit
that referenced
this pull request
Jan 26, 2021
The PR fixes circular dependencies which can be found in the i18n module. Additionally, the PR fixes the code formatting by splitting the summary exports into export assigned to particular functions. This prevents jumping between function declaration or so, and exports. Moreover, the PR fixes an issue that would show up after the update eslint. This happens in the monorepo project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR fixes circular dependencies which can be found in the i18n module.
Additionally, the PR fixes the code formatting by splitting the summary exports into export assigned to particular functions. This prevents jumping between function declaration or so, and exports.
Rollup report:
Moreover, the PR fixes an issue that would show up after the update eslint. This happens in the monorepo project (eslint error).
How has this been tested?
I tested distribution files with Rollup and Webpack.
Types of changes
Checklist: