Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create documentation template #8184

Merged
merged 11 commits into from Jul 8, 2021

Conversation

aninde
Copy link
Contributor

@aninde aninde commented Jun 10, 2021

Context

This PR adds a missing template to reporting issues for documentation.
[skip changelog] The PR does not change the source code or anything related to the build or publishing process so the changelog is not necessary here.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue

Checklist:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d48bf66:

Sandbox Source
vanilla-handsontable-pr Configuration

.github/ISSUE_TEMPLATE/05-documentation.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/05-documentation.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/05-documentation.md Outdated Show resolved Hide resolved
@budnix
Copy link
Member

budnix commented Jul 8, 2021

What is the status of the task? Can we finish it? @aninde @wojciechczerniak @kirszenbaum

@wojciechczerniak
Copy link
Contributor

wojciechczerniak commented Jul 8, 2021

Target branch is wrong, should be merged with docs project.
Template is added twice:
Screenshot 2021-07-08 at 09 29 13

And pls don't create 01.5, 01.75, 01.8423745 pattern. Just rename all the files in the corect order.

@aninde aninde changed the base branch from develop to feature/issue-7624 July 8, 2021 08:01
@aninde
Copy link
Contributor Author

aninde commented Jul 8, 2021

Target branch is wrong, should be merged with docs project.
Template is added twice:
Screenshot 2021-07-08 at 09 29 13

And pls don't create 01.5, 01.75, 01.8423745 pattern. Just rename all the files in the corect order.

Done in d3bf2bc.

Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the templates is changed. Can you fix that?

Before:
image

  • Angular;
  • React;
  • Vue;

After:
image

  • React;
  • Vue;
  • Angular

@aninde
Copy link
Contributor Author

aninde commented Jul 8, 2021

The order of the templates is changed. Can you fix that?

This was intentional as most people use react, but ok I'll go back to how it was. Done in c34e107.

@aninde aninde requested a review from budnix July 8, 2021 09:54
.github/ISSUE_TEMPLATE/02-documentation.md Outdated Show resolved Hide resolved
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aninde aninde requested a review from budnix July 8, 2021 10:45
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it's perfect 👌

@mrpiotr-dev mrpiotr-dev merged commit bbf77c7 into feature/issue-7624 Jul 8, 2021
@mrpiotr-dev mrpiotr-dev deleted the feature/adds-docs-template branch July 8, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants