Add hook beforeFilterValueOptionsShow for customize options order in fiter dropdown menu

[hh54188]

Context

Provide the ability to adjust options order in filter dropdown menu.

How has this been tested?

I have added two tests in filters.spec.js hooks section

• Verify new beforeFilterValueOptionsShow hook will be called before when dropdown is show.
• Verify hook handler could modify dropdown menus order.

Also all unit and e2e tests have passed.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature or improvement (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Additional language file or change to the existing one (translations)

Related issue(s):

• Changing order of “filter by value” data
• Add case sensitive options for filters formulas
• Is it possible customize options order in filter menu?

Affected project(s):

• handsontable
• @handsontable/angular
• @handsontable/react
• @handsontable/vue

Checklist:

• I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
• I have signed the Contributor License Agreement
• My change requires a change to the documentation.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd70668:

Sandbox	Source
vanilla-handsontable-pr	Configuration

[AMBudnik]

Hi @hh54188

Thank you for your effort to share this idea with us.

I see that you have added tests and signed the CLA. Could you also change the branch to develop? We do not accept PRs to the master branch.

[hh54188]

@AMBudnik Sorry about that, I have change the branch to develop

[AMBudnik]

Hi @hh54188

I just got a review summary for your pull request from one of our developers.

There are some aspects that we would need to discuss if we would like to adapt your approach. Firstly, we are cautious about adding new hooks. It is wise to gather more information about specific actions. However, it also forces us to maintain the hook and connections to all of the related plugins. We also see some default actions changed, which leads to a breaking change, not to mention conflicts in files.

Generally, the idea is exciting, and I can imagine why you would like to have this ability. But at this point, I can see two possible approaches

• you can use your solution in your project as a custom code
• We can discuss the subject further on Github Discussions

In both ways, I need to close this pull request and once again thank you for the effort to share this with us.