Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Docs: FIX search shortcuts after route changed. #8375

Merged
merged 2 commits into from Jul 7, 2021

Conversation

Siemienik
Copy link
Contributor

Context

In the listener, I changed the logic of which source elements are valid. It still ignores textareas and other kinds of inputs.

How has this been tested?

Tried to reproduce as described in #8374

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. New docs: Cannot focus search bar input with keyboard shortcuts #8374

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue

Checklist:

@Siemienik Siemienik requested a review from budnix July 7, 2021 06:59
@Siemienik Siemienik linked an issue Jul 7, 2021 that may be closed by this pull request
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0ea9e2a:

Sandbox Source
vanilla-handsontable-pr Configuration

Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much better. However, when the theme switcher or the code-block tab is active:
image
the search hotkeys still not working. Can you improve that?

@Siemienik Siemienik requested a review from budnix July 7, 2021 07:46
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 💪

@Siemienik Siemienik merged commit 72aac29 into feature/issue-7624 Jul 7, 2021
@Siemienik Siemienik deleted the feature/issue-8374 branch July 7, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New docs: Cannot focus search bar input with keyboard shortcuts
2 participants