Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve markdown table's styling #8376

Merged
merged 2 commits into from Jul 8, 2021

Conversation

budnix
Copy link
Member

@budnix budnix commented Jul 7, 2021

Context

The PR improves the markdown table styling. The original PR adds a word-break: break-word; style to the table element. That fixed the table responsiveness for the migration guides page but it worsened the table appearance on other sites.

The PR fixes that by applying the above-mentioned style only for migration guides pages.

Before fix:
image

After fix:
image

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. New docs: [mobile] Tables on the Manual Column move needs some adjustments - first two columns are too narrow #8390

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue

Checklist:

@budnix budnix self-assigned this Jul 7, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0fe37b:

Sandbox Source
vanilla-handsontable-pr Configuration

@budnix budnix marked this pull request as ready for review July 7, 2021 07:32
@budnix budnix requested a review from Siemienik July 7, 2021 07:33
@budnix budnix requested a review from aninde July 7, 2021 10:44
Copy link
Contributor

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@budnix budnix merged commit 476e23f into feature/issue-7624 Jul 8, 2021
@budnix budnix deleted the feature/issue-7624-fix-table-layout branch July 8, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants