Fix Angular examples by linking @handsontable/angular package #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/handsontable into feature/fix-angular-examples
|
Launch the local version of documentation by running: npm run docs:review f7c0e56118546bb5505daf1646aafd2b6d8e2e4a |
jansiegel
approved these changes
Jun 23, 2022
budnix
added a commit
that referenced
this pull request
Jun 23, 2022
The commit is a continuation of #9590. There are some problems with Angular 12 and 13 examples. The PR fixes them by linking not only the handsontable package to the local `node_modules` directory but also the `@handsontable/angular wrapper` (with an exception for Angular 9 and 10 examples).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR is a continuation of #9590. There are some problems with Angular 12 and 13 examples. The PR fixes them by linking not only the
handsontablepackage to the localnode_modulesdirectory but also the@handsontable/angularwrapper (with an exception for Angular 9 and 10 examples).[skip changelog] (hotfix)
How has this been tested?
I tested the changes locally and I pushed the code to the pseudo-release branch to make sure that the GH workflow passes https://github.com/handsontable/handsontable/actions/runs/2547161971.
Types of changes
Related issue(s):
Checklist: