Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP #1

Closed
13 of 40 tasks
wojciechczerniak opened this issue Nov 13, 2019 · 3 comments
Closed
13 of 40 tasks

MVP #1

wojciechczerniak opened this issue Nov 13, 2019 · 3 comments
Assignees
Labels

Comments

@wojciechczerniak
Copy link
Contributor

wojciechczerniak commented Nov 13, 2019

Issue #1 is reserved for our first release 馃帀

Description

WIP

Tasks

Yet to be addressed

  • Undo and redo
  • Copy, cut, paste
  • Merged cells
  • Cell validation
  • Error reporting
  • Moving rows / columns
  • Syntax highlight

Browser support

Browser Name Version
Firefox 58
Safari 11
Chrome 64
iOS Safari 11.2
Chrome for Android 64
IE 11
Edge 16
Android browser 62
Firefox Android 57

Appendix 9

@aninde
Copy link
Contributor

aninde commented Dec 17, 2019

I noticed that support for browsers was probably described as at the beginning of 2018.
e.g.

Browser Name Version Release date Currently used version (as of Dec 2018)
Firefox 58 Jan 2018 71
Safari 11 Sept 2017 13
Chrome 64 Jan 2018 79
Chrome for Android 64 Jan 2018 78/79

It is my responsibility before the first release to check how HyperFormula works in most popular web browsers. IMHO I should test HyperFormula on the latest stable versions of browsers, as our clients will be.

Thus, should we upgrade the versions of the browser in the above description? @wojciechczerniak WDYT?

@wojciechczerniak
Copy link
Contributor Author

We should test on the latest browsers. The list is more a guide which browsers we should check at some point. As a formal requirement, it was already validated by @krzysztofspilka at stage 1, 2 and 3.

@wojciechczerniak
Copy link
Contributor Author

MVP was for 2019 and is now outdated. See #54 for progress

voodoo11 added a commit that referenced this issue Jul 5, 2021
* Tranpose works with any type

* CHANGELOG

* Remove obsolete test

* Allow to move cells in address mapping

* Compare matrices in graph comparator

* Adjust matrices address mapping after adding row

* TODO

* Obsolete test

* Fix cherry-pick

* Compare matrix mappings in graph comparator

* Remove unused code

* Add simple tests

* Move MatrixMapping entries when adding rows

* Spike

* Exchanging matrix vertex works

* Fix addres mapping for simple case of removing row

* Make matrix REF if no space after removing row

* Tidy up

* Shrink matrix before swap

* Fix gathering matrices related to ranges

* Basic tests for removing rows works

* Test with potential CYCLE

* Simplify condition by making use of MatrixSize function

* Reuse and simplify

* Basic cases for setCellContent

* Set no space if writing over matrix

* Shrink matrix during building graph if needed

* Tests cleanup

* Allow to setCellContent onto matrix

* Replacing matrix should work

* We do not forbid to change cell content any more when there is array

* Remove matrix when removing row with corner

* Do not change size of a REFed matrix

* Test for references

* Add test specially for dep correction

* Compare only ref flag

* Fix adjusting edges

* Skipped test for later

* just setNoSpace()

* Test for undo redo and changes

* Keep changes with old content in map

* Ensure range content changes are properly exported

* More specs

* Use string key in ContentChanges

* Gather changes from dependency graph

* Do nothing when trying to set internal array cell empty

* Track SimpleRangeValue changes

* Compare raw input of parsing errors

* Handle ParsingError case

* Cleanup

* Working undo/redo

* Do not allow to move rows inside array

* Update js docs

* Fix rebase

* imports

* Enable tests

* ColumnIndex specs for arrays

* Fix test

* Ensure DependencyGraph changes are cleared after building graph

* Ignore EmptyValue in columnIndex

* Apply array changes in all cases

* Gather changes when removing rows

* Make sure range edges are adjusted properly

* Linter

* Remove console.log

* Cleanup

* Fix lgtm complaints

* Fix browser tests

* Adjust tsdoc

* Update CHANGELOG

* Adjust tsdocs

* SPILL array error

* SPILL instead of REF

* CHANGELOG

* CHANGELOG

* Unused import

Co-authored-by: izulin <izulin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants