Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript, typedoc, vuepress & eslint #1258

Merged
merged 15 commits into from
May 18, 2023
Merged

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Apr 28, 2023

Context

I reduced number of critical vulnerabilities from 7 to 2. To fix the rest we need to update:

Which require a lot of effort. Draft PR: #1262

How did you test your changes?

  • builds correctly
  • docs build correctly
  • unit tests pass

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1239

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Performance comparison of head (1b34854) vs base (104ce4c)

                                     testName |  base |   head |   change
-------------------------------------------------------------------------
                                      Sheet A | 834.2 | 1164.6 |  +39.61%
                                      Sheet B |   388 |  467.2 |  +20.41%
                                      Sheet T | 406.7 |  464.8 |  +14.29%
                                Column ranges | 889.4 |  941.8 |   +5.89%
Sheet A:  change value, add/remove row/column |    46 |     50 |   +8.70%
 Sheet B: change value, add/remove row/column |   464 |    493 |   +6.25%
                   Column ranges - add column |   495 |    575 |  +16.16%
                Column ranges - without batch |   908 |   1049 |  +15.53%
                        Column ranges - batch |   235 |    483 | +105.53%

@sequba sequba marked this pull request as ready for review May 10, 2023 10:40
@sequba sequba self-assigned this May 10, 2023
@sequba sequba linked an issue May 10, 2023 that may be closed by this pull request
@sequba sequba changed the title Update dependencies Update typescript, typedoc, vuepress & eslint May 10, 2023
@sequba
Copy link
Contributor Author

sequba commented May 11, 2023

TODO: check if renamed interfaces are not exposed as public APIs

It's OK. Neither IAddressMappingStrategy nor IArray are public.

@sequba sequba requested a review from wszymanski May 16, 2023 11:40
Copy link
Contributor

@wszymanski wszymanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as desired. Just one minor remark.

const WebpackOnBuildPlugin = require('on-build-webpack');
const fs = require('fs');
const fsExtra = require('fs-extra');
require('string-replace-loader');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move it above declaring variables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this require statement is not needed here. I removed it.

@sequba sequba requested a review from wszymanski May 18, 2023 13:26
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1258 (1b34854) into develop (f6f0102) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1258   +/-   ##
========================================
  Coverage    97.19%   97.19%           
========================================
  Files          166      166           
  Lines        14238    14238           
  Branches      2965     2965           
========================================
  Hits         13838    13838           
  Misses         400      400           
Impacted Files Coverage Δ
...Graph/AddressMapping/ChooseAddressMappingPolicy.ts 100.00% <ø> (ø)
src/helpers/licenseKeyHelper.ts 100.00% <ø> (ø)
src/index.ts 100.00% <ø> (ø)
src/interpreter/InterpreterValue.ts 100.00% <ø> (ø)
src/parser/LexerConfig.ts 100.00% <ø> (ø)
src/ArrayValue.ts 100.00% <100.00%> (ø)
...c/DependencyGraph/AddressMapping/AddressMapping.ts 88.00% <100.00%> (ø)
...rc/DependencyGraph/AddressMapping/DenseStrategy.ts 100.00% <100.00%> (ø)
...c/DependencyGraph/AddressMapping/SparseStrategy.ts 100.00% <100.00%> (ø)
src/DependencyGraph/FormulaCellVertex.ts 84.00% <100.00%> (ø)
... and 8 more

@sequba sequba merged commit 1715cdd into develop May 18, 2023
@sequba sequba deleted the feature/issue-1239 branch May 18, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 critical vulnerabilities in npm audit report
2 participants