-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pu/vectorization #673
Pu/vectorization #673
Conversation
This pull request introduces 39 alerts and fixes 12 when merging 98ad66d into 7ff3ab7 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 38 alerts when merging 98ad66d into 027597f - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #673 +/- ##
===========================================
- Coverage 92.36% 92.27% -0.10%
===========================================
Files 166 166
Lines 39089 39163 +74
Branches 5349 5355 +6
===========================================
+ Hits 36106 36138 +32
- Misses 2947 2986 +39
- Partials 36 39 +3
|
This pull request introduces 38 alerts when merging 29177f4 into b0dc57f - view on LGTM.com new alerts:
|
This pull request introduces 38 alerts when merging 23ae7d7 into be763b4 - view on LGTM.com new alerts:
|
This pull request introduces 38 alerts when merging 8a00d3f into be763b4 - view on LGTM.com new alerts:
|
/** | ||
* Some function do not allow vectorization: array-output, and special functions. | ||
*/ | ||
vectorizationForbidden?: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added to the docs: https://handsontable.github.io/hyperformula/guide/custom-functions.html#implementedfunction-property
I think we forgot to update, more properties are missing :|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are subtle differences between parameters that are used by the core engine, and parameters that are just a guiding info for our wrappers.
That is, unless the custom function is written in a manner that supports vectorization, NOT setting vectorizationForbidden
will not produce valid result anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yet, all those parameters may be used for custom function, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are all passed. But some of those have no effect unless explicitly used by the function implementation.
This pull request introduces 38 alerts when merging 6b5092d into 94c3d72 - view on LGTM.com new alerts:
|
This pull request introduces 38 alerts when merging 8d0c3c5 into 94c3d72 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Context
Vectorization of scalar functions.
How has this been tested?
Types of changes
Related issue(s):
Checklist: