Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Make a workaround for the cssstyle package. #65

Closed
jansiegel opened this issue Jul 10, 2018 · 1 comment
Closed

Make a workaround for the cssstyle package. #65

jansiegel opened this issue Jul 10, 2018 · 1 comment
Assignees
@jansiegel
Labels
Type: Improvement suggestion
Milestone
September 2018

Comments

@jansiegel
Copy link
Member

Currently, one of the devDependencies is my fork of the cssstyle package. (More information here: jsdom/cssstyle#63).
This is not an optimal solution, plus it breaks npm audit, as it's not published to npm.

The new approach overwrites the Number prototype by adding toLowerCase and split methods for the tests, as they break on them specifically.
@jansiegel jansiegel self-assigned this Jul 10, 2018
jansiegel added a commit that referenced this issue Jul 10, 2018
@jansiegel
Add a workaround for the cssstyle package. #65
d991bbd
jansiegel added a commit that referenced this issue Jul 10, 2018
@jansiegel
- Extend the mocked methods
37e545c 
- Force travis to use node 8
- Remove unneeded jest globals from the config
#65
jansiegel added a commit that referenced this issue Jul 10, 2018
@jansiegel
Make a workaround for the cssstyle package. (#66)
5cc6124 
* Add a workaround for the `cssstyle` package. #65

* - Extend the mocked methods
- Force travis to use node 8
- Remove unneeded jest globals from the config
#65
@wojciechczerniak
Copy link
Contributor

Fix for CSSStyleDeclaration in jsdom/cssstyle#52 was merged and released as 1.0.0: https://github.com/jsakas/CSSStyleDeclaration/releases/tag/v1.0.0

@jansiegel Maybe we should revert this workaround? 💔

@wojciechczerniak wojciechczerniak mentioned this issue Aug 22, 2018
Closed
11 tasks
@jansiegel jansiegel mentioned this issue Sep 11, 2018
Merged
10 tasks
@wojciechczerniak wojciechczerniak added this to the September 2018 milestone Sep 14, 2018
@wojciechczerniak wojciechczerniak mentioned this issue Oct 26, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jansiegel jansiegel

Labels
Type: Improvement suggestion
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@wojciechczerniak @jansiegel @AMBudnik