Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow install with PHP 8.0 #54

Closed
wants to merge 3 commits into from
Closed

Allow install with PHP 8.0 #54

wants to merge 3 commits into from

Conversation

caugner
Copy link

@caugner caugner commented Dec 2, 2020 •
edited
Loading

See #53.

@kaystrobach
Copy link
Collaborator

is there anything against having ^7.1 || ^8.0 imho this is clearer and would avoid future problems.

@caugner
Copy link
Author

caugner commented Dec 2, 2020

@kaystrobach IMO opinion >= 7.1 is preferable because it avoids the current situation in the first place (for 9.0).

@hanneskod
Copy link
Owner

Hi @caugner and thank you for taking the time to fix this!

I agree with @kaystrobach though, as we actually don't know if it is compatible with php 9.

Could you please also add 8.0 to .travis.yml.

kaystrobach
kaystrobach reviewed Dec 4, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@hanneskod hanneskod closed this in d91f990 Dec 7, 2020
@FabianKoestring
Copy link

Thanks! Will you tag a new release?

@caugner caugner deleted the patch-1 branch December 7, 2020 11:04
@hanneskod
Copy link
Owner

Yupp, good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaystrobach kaystrobach kaystrobach left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caugner @kaystrobach @hanneskod @FabianKoestring