Skip to content

Commit

Permalink
Fix some golint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
mvdan committed Mar 31, 2015
1 parent a01888e commit cd1a7dc
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 35 deletions.
3 changes: 1 addition & 2 deletions fs/fs.go
Expand Up @@ -419,9 +419,8 @@ func (n *folderNode) Rename(oldName string, newParent nodefs.Node, newName strin
// TODO - delete destination?
log.Printf("old folder already has child %q", newName)
return fuse.ENOSYS
} else {
// does mtp overwrite the destination?
}
// does mtp overwrite the destination?
}

if fn != n {
Expand Down
60 changes: 29 additions & 31 deletions mtp/device_test.go
Expand Up @@ -98,26 +98,25 @@ func TestAndroid(t *testing.T) {
if err != nil {
t.Errorf("AndroidBeginEditObject: %v", err)
return
} else {
err = dev.AndroidTruncate(handle, int64(magicSize))
if err != nil {
t.Errorf("AndroidTruncate: %v", err)
}
buf := bytes.NewBufferString(magicStr)
err = dev.AndroidSendPartialObject(handle, int64(magicOff), uint32(buf.Len()), buf)
if err != nil {
t.Errorf("AndroidSendPartialObject: %v", err)
}
if buf.Len() > 0 {
t.Errorf("buffer not consumed")
}
err = dev.AndroidEndEditObject(handle)
if err != nil {
t.Errorf("AndroidEndEditObject: %v", err)
}
}
err = dev.AndroidTruncate(handle, int64(magicSize))
if err != nil {
t.Errorf("AndroidTruncate: %v", err)
}
buf := bytes.NewBufferString(magicStr)
err = dev.AndroidSendPartialObject(handle, int64(magicOff), uint32(buf.Len()), buf)
if err != nil {
t.Errorf("AndroidSendPartialObject: %v", err)
}
if buf.Len() > 0 {
t.Errorf("buffer not consumed")
}
err = dev.AndroidEndEditObject(handle)
if err != nil {
t.Errorf("AndroidEndEditObject: %v", err)
}

buf := &bytes.Buffer{}
buf = &bytes.Buffer{}
err = dev.GetObject(handle, buf)
if err != nil {
t.Errorf("GetObject: %v", err)
Expand Down Expand Up @@ -150,19 +149,18 @@ func TestAndroid(t *testing.T) {
if err != nil {
t.Errorf("AndroidBeginEditObject: %v", err)
return
} else {
buf := bytes.NewBufferString(magicStr)
err = dev.AndroidSendPartialObject(handle, int64(magicSize), uint32(buf.Len()), buf)
if err != nil {
t.Errorf("AndroidSendPartialObject: %v", err)
}
if buf.Len() > 0 {
t.Errorf("buffer not consumed")
}
err = dev.AndroidEndEditObject(handle)
if err != nil {
t.Errorf("AndroidEndEditObject: %v", err)
}
}
buf = bytes.NewBufferString(magicStr)
err = dev.AndroidSendPartialObject(handle, int64(magicSize), uint32(buf.Len()), buf)
if err != nil {
t.Errorf("AndroidSendPartialObject: %v", err)
}
if buf.Len() > 0 {
t.Errorf("buffer not consumed")
}
err = dev.AndroidEndEditObject(handle)
if err != nil {
t.Errorf("AndroidEndEditObject: %v", err)
}
buf = &bytes.Buffer{}
err = dev.GetObject(handle, buf)
Expand Down
4 changes: 2 additions & 2 deletions mtp/encoding.go
Expand Up @@ -197,11 +197,11 @@ func encodeTime(w io.Writer, f reflect.Value) error {
}

out := make([]byte, 2*len(s)+3)
out, err := encodeStr(out, s)
enc, err := encodeStr(out, s)
if err != nil {
return err
}
_, err = w.Write(out)
_, err = w.Write(enc)
return err
}

Expand Down

0 comments on commit cd1a7dc

Please sign in to comment.