Mergemain #14
Merged
Mergemain #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stio#40967) This reverts commit c123ccd.
* istio: improve deep copy for service attributes DeepCopy using reflection is super slow, and a big chunk of init push context time is doing deep copy. This is already improved a lot by this PR: istio#37932 (init push context time drop from 1m30s to 40s). ServiceAttribute DeepCopy is still taking more than 10% cpu time, so improving this function can further reduce the init push context time and hence our propagation delay. Benchmark results: (before) goos: darwin goarch: amd64 pkg: istio.io/istio/pilot/pkg/model cpu: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz BenchmarkServiceDeepCopy BenchmarkServiceDeepCopy-16 132760 8190 ns/op PASS (after) goos: darwin goarch: amd64 pkg: istio.io/istio/pilot/pkg/model cpu: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz BenchmarkServiceDeepCopy BenchmarkServiceDeepCopy-16 1213035 1019 ns/op PASS Change-Id: Ied3e81d252ccf226bbb8d1d56eb88bff7c146af4 Reviewed-on: https://gerrit.musta.ch/c/public/istio/+/3700 Reviewed-by: Douglas Jordan <douglas.jordan@airbnb.com> Reviewed-by: Weibo He <weibo.he@airbnb.com> * istio: fix lint AddressMap contains a mutex which govet complains if we return a copy, ignoring the vet error (behavior is the same as before). Change-Id: If0274e6e1412eb50586ea609a07c302557297ad8 Reviewed-on: https://gerrit.musta.ch/c/public/istio/+/3706 Reviewed-by: Weibo He <weibo.he@airbnb.com>
* Update service.go * Update service.go
* Add full fuzz tests for deepcopy * banner
Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
* Update sets package to be generic * Move usages over to generic * Drop intset * fix missing intset * rename file * add benchmark * Add benchmark and alias * Add String alias * Simplify usages * gen * gen
* fuzzers: workaround lack of t.Skip() in oss-fuzz * license * remove tmp
* Add gateway-api configuration to helloworld sample * small fix * fix lint * address reviewer comments * tweak wording
Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io>
…ceSele… (istio#41020) * Exclude kube-system from auto.sidecar-injector.istio.io namespaceSelector * Exclude all system namespaces * Include release note
* Implement "match" clause of WasmPlugin * Add the release note * Change ShouldApplyTo -> MatchListener * Reflect the comments * Describe the details of a testcase * Update releasenotes/notes/wasm-traffic-selector.yaml Co-authored-by: Greg Hanson <gregory.hanson@solo.io> * Reflect the comments and add the validation Co-authored-by: Greg Hanson <gregory.hanson@solo.io>
* consolidate on istio `Set` package instead of k8s Note: `List` in the old library is sorted. * fix build * rebase
* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <howardjohn@google.com> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <howardjohn@google.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io>
* add benchmarks * replace sync.Map
Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
* Update go-control-plane * Run make gen * Removed total weight check * Update envoy/go-control-plane * Make gen
* [WIP] integration tests for sidecar egress tls origination Signed-off-by: Faseela K <faseela.k@est.tech> * Fix lint Signed-off-by: Faseela K <faseela.k@est.tech> * Move the test under /security to avoid extra setup cost Signed-off-by: Faseela K <faseela.k@est.tech> Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com> Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>
* lint: cleancode * fix gen and lint * update
…tio#41441) * replace stats with native Signed-off-by: Kuat Yessenov <kuat@google.com> * ignore telemetry api Signed-off-by: Kuat Yessenov <kuat@google.com> * make gen Signed-off-by: Kuat Yessenov <kuat@google.com> * any in any Signed-off-by: Kuat Yessenov <kuat@google.com> * fix Signed-off-by: Kuat Yessenov <kuat@google.com> * missing stat tag Signed-off-by: Kuat Yessenov <kuat@google.com> * ignore telemetry api Signed-off-by: Kuat Yessenov <kuat@google.com> * reapply Signed-off-by: Kuat Yessenov <kuat@google.com> * try asan Signed-off-by: Kuat Yessenov <kuat@google.com> * Revert "try asan" This reverts commit 02e68c399a98f63586040ba210b64b611d2b9158. * only enable for telemetry api Signed-off-by: Kuat Yessenov <kuat@google.com> * finish Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.