Allow gzipped barcode whitelist file. #127
Merged
+92
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haowenz
requested changes
Dec 7, 2022
|
btw, did you test this on whitelist files in gz and normal txt formats? |
|
Yes, I have tested on uncompressed and gzipped whitelist files, and they generated the same results. I'll address the other comments you mentioned later. |
haowenz
approved these changes
Dec 7, 2022
|
Thank you for adding this feature. Please bump up the version before rebase. |
|
Will this change also support loading translation table in gz format? |
|
Not yet. I can add that after the paired-end sam format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I leave the original ifstream code there in case we still need it in the future.