-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How dis.merge works? #31
Comments
It's an ad hoc procedure. If two regions are closer than dis.merge, they will be merged into one. Can you provide some example that violates this? I need to check codes. |
It seems it does not work when the dis.merge is greater than the minlen. I set minlen to 100 and tried different dis.merge. At dis.merge greater than minlen all the results were the same. For example here minlen is 100 and dis.merge is 500 and these three should be merged into one:
I guess the following lines in the DMR.R file might force the maximum possible dis.merge to be as minlen?
Thanks, |
Yes that's what I did. I think if the gap is greater than the minimum allowable length of a DMR, one shouldn't merge them. |
Sorry, The first two lines should be merged the third one shows hypermethylation. |
Then providing greater dis.merge than minlen is not doing anything? Isn't it make sense to allow that? at least for large DMRs? |
yes that's what I did. I can't check the length of each DMR and then determine a proper dis.merge. I just don't want to merge, say, two 100bp DMRs that are 500bp away. There's no specific reason. Again as I said, it's an ad hoc procedure. |
Thanks @haowulab . It would be also great if you could mention this in the documentation’s help so users be aware. Because there you also specified a dis.merge greater than the minlen: “ Usage |
Hi,
I was wondering how dis.merge in callDMRs works? In the dis.merge help it says:
“ When two DMRs are very close to each other and the distance (in bps) is less than this number, they will be merged into one.”
However, it seems in the results there are regions closer than specified dis.merge which did not merged into one.
Thanks,
Vahid
The text was updated successfully, but these errors were encountered: