Extension domains configuration for the fhr instance validator #917
Conversation
| @@ -70,18 +71,24 @@ public FhirInstanceValidator(IValidationSupport theValidationSupport) { | |||
| myValidationSupport = theValidationSupport; | |||
| } | |||
|
|
|||
| private String determineResourceName(Document theDocument) { | |||
| Element root = null; | |||
| public FhirInstanceValidator setExtensionDomains(List<String> extensionDomains) { | |||
There was a problem hiding this comment.
This is very cool. Would you mind to add some javadoc to the setExtensionDomains indicating what the values would be and what the impact of setting them is? I'm assuming that the actual term "extension domain" comes from InstanceValidator so it's probably worth preserving that term, but it's not very intuitive what it would be. :)
There was a problem hiding this comment.
Sorry, I somehow missed your comment.
And, yes I will of course do it. I will just take a few hours since at the moment I am a bit swamped.
But it should only be hours ...
hdconradi
force-pushed
the
extension_domains_configuration_in_fhr_instance_validator
branch
from
d6416f0
to
e87d827
Compare
|
I have added a bit javadoc and renamed those methods from |
hdconradi
force-pushed
the
extension_domains_configuration_in_fhr_instance_validator
branch
from
e87d827
to
46f7e9d
Compare
|
Rebase after 3.4 |
hdconradi
force-pushed
the
extension_domains_configuration_in_fhr_instance_validator
branch
from
46f7e9d
to
c3232f8
Compare
|
Rebase after 3.5.0 |
http://hl7.org/fhir/tools/StructureDefinition/ -> http://hl7.org/fhir/StructureDefinition/ That makes the entry for the structuredefinition-expression superfluous. The url behind IG_DEPENDSON_PACKAGE_EXTENSION does not point is not (yet?) valid too.
The for loop was completely superfluous beforehand. Either fix it as e.g. in this patch or remove it.
- javadoc see - use diamond operator for generics - remove throws clause when exception is not thrown - add TODO's for some cases a NPE might occur. My knowledge of the context is not sufficient to suggest the proper way to solve this.
hdconradi
force-pushed
the
extension_domains_configuration_in_fhr_instance_validator
branch
from
c3232f8
to
a8957b9
Compare
|
Rebase after 3.6 |
|
Hi @hdconradi - Sorry this took so long to merge, and many thanks for keeping it up to date. I'm merging it now so you don't need to do this any longer. :) |
hdconradi
deleted the
extension_domains_configuration_in_fhr_instance_validator
branch
Creating larger questionnaires with extension domains will currently produce lot's of information messages with regard
Unkown extensionswhich might drown the more critical warnings and errors.The
InstanceValidatoralready has a data structure which is used for registeringextension domains, but this data structure is not exposed to client code.The first of patch for this branch add the necessary functionality for the
FhirInstanceValidatorin DSTU3 and R4 and the second patch add two tests.The third and fourth patch are not really about this functionality and can in priniciple remove from this branch and/or moved in their own branches.
The third patch fixes and obvious bug when intialising the
FhirInstanceValidatorand the forth one tackles a variety of different less important issues.