New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy over the profile picture from Facebook? #297
Comments
you can access the picture by the
|
Yes, but picture is not there in the raw JSON, because the code doesn't
request that field from Facebook. See my proposed code changes. Thanks!
Teg
…On Tue, Feb 21, 2017 at 5:48 AM, Pankaj Patel ***@***.***> wrote:
you can access the picture by the raw as raw.profile.picture.
raw contains the JSON profile response received.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMm2OX-4_uW0GimM07-xjP7_ulopfXpbks5reus9gaJpZM4ME7-i>
.
|
@grenager You are right; though there would be many fields which facebook provides which can be included in the query. I think it will be good to have an option for the provider to accept query param for the default request. |
Great idea, thanks Pankaj.
…On Mon, Feb 27, 2017 at 12:54 PM, Pankaj Patel ***@***.***> wrote:
@grenager <https://github.com/grenager> You are right; though there would
be many fields which facebook provides which can be included in the query.
I think it will be good to have an option for the provider to accept query
param for the default request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#297 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMm2OXAxr8YUktJ7Em8HeKVkHR-Xnq7jks5rgzftgaJpZM4ME7-i>
.
|
Any update on this? Is there any way to make it so it requests the profile image as well? I see we can directly modify the core provider code to add this, but that isn't a particularly great solution. |
@ricktbaker PR needs to be submitted for this to make profile picture available as well. |
This commit adds a new option (and the first) configuration option to the Facebook provider: `fields`, which allows to request additional profile fields if needed. This should be a non-breaking change, as the `fields` option has a default value. Fix hapijs#297
This commit adds a new option (and the first) configuration option to the Facebook provider: `fields`, which allows to request additional profile fields if needed. This should be a non-breaking change, as the `fields` option has a default value. Fix hapijs#297
I just submitted a PR to fix this issue, feedback and comments are welcome 👍 You will be able to specify the fields you want to retrieve from the user's profile, which will be available in |
This commit adds a new option (and the first) configuration option to the Facebook provider: `fields`, which allows to request additional profile fields if needed. This should be a non-breaking change, as the `fields` option has a default value. Fix hapijs#297
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Hi, it would be really helpful for me to get the profile picture from Facebook. Here's the required code change (I think):
Better yet, it would be cool to allow users to specify the paths of the fields they want to copy out of the profiles into the session objects.
The text was updated successfully, but these errors were encountered: