Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields option to Facebook provider #315

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Add fields option to Facebook provider #315

merged 1 commit into from
Sep 24, 2017

Conversation

PaulMougel
Copy link
Contributor

This commit adds a new option (and the first) configuration option
to the Facebook provider: fields, which allows to request
additional profile fields if needed.

This should be a non-breaking change, as the fields option has a
default value.

Fix #297

@PaulMougel
Copy link
Contributor Author

Looks like Travis failed on a specific version; any advice on how to fix it?

@pankajpatel
Copy link
Contributor

Maybe this will help: hapijs/hapi#2474

hapi is devDependency and that's why npm might not install hapi's dependencies (mimos).

@AdriVanHoudt
Copy link
Contributor

It is only on hapi 15, did the shrinkwrap change in that version or something?

@PaulMougel
Copy link
Contributor Author

Something looks fishy, previous PRs seem to build just fine on Travis with hapi 15.

@Marsup
Copy link
Contributor

Marsup commented Jun 13, 2017

@ldesplat Temporarily fixed by 5193b17 to unblock this PR, feel free to have another strategy.

@PaulMougel Rebase your PR on latest master, it should work.

@PaulMougel
Add fields option to Facebook provider
b3cb4f6 
This commit adds a new option (and the first) configuration option
to the Facebook provider: `fields`, which allows to request
additional profile fields if needed.

This should be a non-breaking change, as the `fields` option has a
default value.

Fix hapijs#297
@PaulMougel
Copy link
Contributor Author

Looks good 👍

@ldesplat
Copy link
Contributor

That's very useful, thank you!

@ldesplat ldesplat added this to the 8.8.0 milestone Sep 24, 2017
@ldesplat ldesplat added the feature New functionality or improvement label Sep 24, 2017
@ldesplat ldesplat merged commit 15954cb into hapijs:master Sep 24, 2017
@PaulMougel PaulMougel deleted the add-facebook-fields branch September 29, 2017 19:41
@PaulMougel
Copy link
Contributor Author

You're welcome. Thank you for the merge!

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New functionality or improvement
Projects
None yet
Milestone
8.8.0
Development

Successfully merging this pull request may close these issues.

Copy over the profile picture from Facebook?
5 participants
@PaulMougel @pankajpatel @AdriVanHoudt @Marsup @ldesplat