Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `fields` option to Facebook provider #315

Merged
merged 1 commit into from Sep 24, 2017

Conversation

@PaulMougel
Copy link
Contributor

PaulMougel commented Jun 10, 2017

This commit adds a new option (and the first) configuration option
to the Facebook provider: fields, which allows to request
additional profile fields if needed.

This should be a non-breaking change, as the fields option has a
default value.

Fix #297

@PaulMougel

This comment has been minimized.

Copy link
Contributor Author

PaulMougel commented Jun 10, 2017

Looks like Travis failed on a specific version; any advice on how to fix it?

@pankajpatel

This comment has been minimized.

Copy link
Contributor

pankajpatel commented Jun 10, 2017

Maybe this will help: hapijs/hapi#2474

hapi is devDependency and that's why npm might not install hapi's dependencies (mimos).

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Jun 12, 2017

It is only on hapi 15, did the shrinkwrap change in that version or something?

@PaulMougel

This comment has been minimized.

Copy link
Contributor Author

PaulMougel commented Jun 13, 2017

Something looks fishy, previous PRs seem to build just fine on Travis with hapi 15.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Jun 13, 2017

@ldesplat Temporarily fixed by 5193b17 to unblock this PR, feel free to have another strategy.

@PaulMougel Rebase your PR on latest master, it should work.

This commit adds a new option (and the first) configuration option
to the Facebook provider: `fields`, which allows to request
additional profile fields if needed.

This should be a non-breaking change, as the `fields` option has a
default value.

Fix #297
@PaulMougel PaulMougel force-pushed the PaulMougel:add-facebook-fields branch from f215ec8 to b3cb4f6 Jun 13, 2017
@PaulMougel

This comment has been minimized.

Copy link
Contributor Author

PaulMougel commented Jun 13, 2017

Looks good 👍

@ldesplat

This comment has been minimized.

Copy link
Contributor

ldesplat commented Sep 24, 2017

That's very useful, thank you!

@ldesplat ldesplat added this to the 8.8.0 milestone Sep 24, 2017
@ldesplat ldesplat added the feature label Sep 24, 2017
@ldesplat ldesplat merged commit 15954cb into hapijs:master Sep 24, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PaulMougel PaulMougel deleted the PaulMougel:add-facebook-fields branch Sep 29, 2017
@PaulMougel

This comment has been minimized.

Copy link
Contributor Author

PaulMougel commented Sep 29, 2017

You're welcome. Thank you for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.