-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hapi 17 #26
Support hapi 17 #26
Conversation
Should I update also the |
Yep, to match the other modules. |
Updated travis file. Also made some refactors and fixed some tests to reach 100% coverage |
Could you take a look at this PR? Thanks! |
Need to find someone who uses this to review. |
I have tested this out with my app and the caching is working, one thing I noticed though is that if the memcached server goes down after startup this.isConnected is still true so the request just gets stuck with no timeout/error |
@anthony-dibenedetto-olx Can you look into this issue? |
@hueniverse Meanwhile @jamesgibson14 if you want to help I wouldn't mind. Eran, how do I / we proceed on this case? This PR is still unmerged and if James wanted to help he wouldn't be able to send a PR, unless it is against this branch. Another thing I noticed is that this module doesn't have releases, unlike the other catbox-* modules. Is there a reason for that? |
I was unable to get any response from @chapel who is the only one with access rights on npm. I've emailed him and waiting to hear back. You should be able to merge the code to the repo though. Let me know if you were not added (via your personal account as requested). |
@hueniverse yes, I can merge the code. I'll do that |
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
What does this PR do?
Related to issue #24