Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow timezone to be specified for expiresAt values #112

Closed
hueniverse opened this issue Nov 5, 2014 · 4 comments · Fixed by #132
Closed

Allow timezone to be specified for expiresAt values #112

hueniverse opened this issue Nov 5, 2014 · 4 comments · Fixed by #132
Assignees
@hueniverse
Labels
feature New functionality or improvement

Comments

@hueniverse
Copy link
Contributor

Moved here from hapijs/hapi#1748
@operatorjen
Copy link

It seems that specifying a custom timezone would cause problems when daylight saving happens. For instance, in PST vs PDT - if a user were to set a custom timezone of -7 on their caching TTL but then it is the same evening that -8 switches over, that could cause some problems on when the cache is reset.

@hueniverse
Copy link
Contributor Author

That should be the responsibility of the developer using this feature.

jagoda added a commit to jagoda/catbox that referenced this issue Aug 3, 2015
@jagoda
Allow time zone specification for expiresAt values.
fa44fcc 
This change introduces a 'timezone' option for cache policy objects
that determines which time zone the 'expiresAt' time is relative to.
Time zones may be specified either as a fixed offset (ex. -0800) or
as a IANA time zone name (ex. America/Los_Angeles). When using a
named time zone, daylight savings time will be accounted for
automatically.

Closes hapijs#112.
@jagoda jagoda mentioned this issue Aug 3, 2015
Closed
jagoda added a commit to jagoda/catbox that referenced this issue Aug 3, 2015
@jagoda
Allow time zone specification for expiresAt values.
63770fc 
This change introduces a 'timezone' option for cache policy objects
that determines which time zone the 'expiresAt' time is relative to.
Time zones may be specified either as a fixed offset (ex. -0800) or
as a IANA time zone name (ex. America/Los_Angeles). When using a
named time zone, daylight savings time will be accounted for
automatically.

Closes hapijs#112.
@jagoda jagoda mentioned this issue Aug 3, 2015
Merged
@hueniverse hueniverse self-assigned this Aug 9, 2015
@hueniverse
Copy link
Contributor Author

I changed my mind about this. I don't want to support timezones anymore.

@Marsup Marsup added feature New functionality or improvement and removed request labels Sep 21, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
feature New functionality or improvement
Projects
None yet
Milestone
No milestone
3 participants
@hueniverse @operatorjen @Marsup